aws_acm_certificate: fix false positive for private CA
#455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bendrucker Hi Ben, thank you for always helping me. Any updates on this? If you're busy, I can work on this. |
|
Haven't had a chance to finish this up, feel free to take over! |
%q escapes tab char to \t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handles
certificate_authority_arnfor anaws_acm_certificate. Closes #453.This ran up against issues with the test generator, which fails to account for
truncateLongMessagein the tests. This is marked as a draft so that this can be fixed and then this change can be rebased on top.