Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_security_group_invalid_protocol rule #356

Merged
merged 5 commits into from
Jul 14, 2022
Merged

Add aws_security_group_invalid_protocol rule #356

merged 5 commits into from
Jul 14, 2022
+266 −0

Conversation

x-color
Copy link
Member

@x-color x-color commented Jul 10, 2022

Add aws_security_group_invalid_protocol rule.

This rule checks whether protocol in an inline rule block has an invalid value as protocol.

wata727
wata727 reviewed Jul 10, 2022
View reviewed changes
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are same suggestions as #355 (review)

@x-color
Copy link
Member Author

x-color commented Jul 13, 2022

@wata727
Thank you for reviewing my PR!
I fixed them.

@wata727 wata727 merged commit 6986646 into terraform-linters:master Jul 14, 2022
@wata727
Copy link
Member

wata727 commented Jul 14, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wata727 wata727 wata727 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x-color @wata727