Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for IAM policy document without Sid #176

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Fix false positive for IAM policy document without Sid #176

merged 1 commit into from
Sep 2, 2021

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Aug 31, 2021

See #149 (comment)

Probably, this is a valid case :)

@wata727 wata727 requested a review from Rihoj August 31, 2021 18:00
Rihoj
Rihoj approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@Rihoj Rihoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense to me.

@wata727 wata727 merged commit 766cff0 into master Sep 2, 2021
@wata727 wata727 deleted the fix_false_positive_for_no_sid branch September 2, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rihoj Rihoj Rihoj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wata727 @Rihoj