Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_elasticache_replication_group same basic rules #140

Closed
ghost opened this issue Jul 16, 2021 · 1 comment · Fixed by #143
Closed

aws_elasticache_replication_group same basic rules #140

ghost opened this issue Jul 16, 2021 · 1 comment · Fixed by #143
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jul 16, 2021

It looks like aws_elasticache_replication_group could use some of the rules as aws_elasticache_cluster such as node type, default parameter group, etc. Is this of interest to the community?
@wata727
Copy link
Member

wata727 commented Jul 17, 2021

Looks good 👍

@wata727 wata727 added the enhancement New feature or request label Jul 17, 2021
Rihoj pushed a commit to Rihoj/tflint-ruleset-aws that referenced this issue Jul 19, 2021
aws_elasticache_replication_group - fixes terraform-linters#140 Add t…
eaa469f 
…ests fir aws_elasticache_replication_group # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Date: Mon Jul 19 15:34:06 2021 -0400 # # On branch aws_elasticache_replication_group # Changes to be committed: # modified: docs/rules/aws_elasticache_cluster_default_parameter_group.md # new file: docs/rules/aws_elasticache_replication_group_default_parameter_group.md # new file: rules/aws_elasticache_replication_group_default_parameter_group.go # new file: rules/aws_elasticache_replication_group_default_parameter_group_test.go # new file: rules/aws_elasticache_replication_group_invalid_type.go # new file: rules/aws_elasticache_replication_group_invalid_type_test.go #
@Rihoj Rihoj mentioned this issue Jul 19, 2021
Merged
wata727 pushed a commit that referenced this issue Jul 23, 2021
@Rihoj
aws_elasticache_replication_group (#143)
2d95a80 
* aws_elasticache_replication_group -  fixes #140 Add tests fir aws_elasticache_replication_group # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Date: Mon Jul 19 15:34:06 2021 -0400 # # On branch aws_elasticache_replication_group # Changes to be committed: # modified: docs/rules/aws_elasticache_cluster_default_parameter_group.md # new file: docs/rules/aws_elasticache_replication_group_default_parameter_group.md # new file: rules/aws_elasticache_replication_group_default_parameter_group.go # new file: rules/aws_elasticache_replication_group_default_parameter_group_test.go # new file: rules/aws_elasticache_replication_group_invalid_type.go # new file: rules/aws_elasticache_replication_group_invalid_type_test.go #

* aws_elasticache_replication_group -  Fix variable, and registered to provider

* aws_elasticache_replication_group -  Add to readme

* aws_elasticache_replication_group -  Add docs for rule and register with provider

* aws_elasticache_replication_group -  Add missing docs

* aws_elasticache_replication_group -  Add previous type rule for replication group

Co-authored-by: James Ray <jray@five-startech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aws_elasticache_replication_group Rihoj/tflint-ruleset-aws
1 participant
@wata727