Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default values inside override.json #704

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

akocbek
Copy link
Contributor

@akocbek akocbek commented Feb 9, 2024

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@akocbek
Copy link
Contributor Author

akocbek commented Feb 9, 2024

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @akocbek - did you try a test to ensure the override works now with one of the patterns? (you would have to set override = true to test it).

@akocbek
Copy link
Contributor Author

akocbek commented Feb 12, 2024

we had to remove activity_tracking and metrics_monitoring because they require valid CRN (e.q. activity_tracker_crn) which we don't have it at that stage. If we remove activity_tracker_crn or metrics_monitoring_crn only then we get the following:

│ The given value is not suitable for module.roks_landing_zone.module.landing_zone.var.cos declared at ../../variables.tf:480,1-15: element 0: attribute "buckets": element 0: attribute "metrics_monitoring":
│ attribute "metrics_monitoring_crn" is required.

@akocbek
Copy link
Contributor Author

akocbek commented Feb 12, 2024

/run pipeline

@ocofaigh ocofaigh merged commit 3330136 into main Feb 13, 2024
2 checks passed
@ocofaigh ocofaigh deleted the update_override branch February 13, 2024 10:37
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 5.15.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants