feat: Scope Policy To Exact KMS Key #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
|
@Vipin654, in PR template
|
|
@Ak-sky UPGRADE test has to be skipped because Auth Policy will be destroyed and re-created which is a breaking change. I have Pasted screenshot for your reference. |
|
/run pipeline |
Ak-sky
reviewed
Jan 16, 2025
Ak-sky
reviewed
Jan 16, 2025
main.tf
Outdated
| count = (var.kms_encryption_enabled && !var.skip_iam_authorization_policy) ? 1 : 0 | ||
| source_service_name = "appid" | ||
| source_resource_group_id = var.resource_group_id | ||
| description = "Allow all AppID instances in the given resource group reader access to KMS instance ${var.existing_kms_instance_guid}" |
There was a problem hiding this comment.
Description should be like this if source is scoped to resource group id.
Suggested change
| description = "Allow all AppID instances in the given resource group reader access to KMS instance ${var.existing_kms_instance_guid}" | |
| description = "Allow all AppID instances in the given resource group ${var.resource_group_id} to read the ${local.kms_service} key ${local.kms_key_id} from instance ${var.existing_kms_instance_guid}" |
There was a problem hiding this comment.
Description has been changed.
|
/run pipeline |
Ak-sky
previously approved these changes
Jan 18, 2025
ocofaigh
reviewed
Jan 20, 2025
ocofaigh
requested changes
Jan 20, 2025
|
/run pipeline |
ocofaigh
approved these changes
Jan 20, 2025
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scoping IAM Auth Policy to a specific key in the key protect instance instead of targeting the whole instance.
[Git Issue] : #243
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Scoping IAM Auth Policy to a specific key in the key protect instance instead of targeting the whole instance.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers