SKIP UPGRADE TEST #259
Closed
SKIP UPGRADE TEST #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
ocofaigh
requested changes
Dec 12, 2024
| module "crn_parser" { | ||
| source = "terraform-ibm-modules/common-utilities/ibm//modules/crn-parser" | ||
| version = "1.1.0" | ||
| crn = var.kms_key_crn |
There was a problem hiding this comment.
kms_key_crn is optional. Meaning it could have a value of null. Meaning this module call would fail. You need to add a count around it to ensure its only called if kms_key_crn is not null
main.tf
Outdated
| @@ -7,15 +13,11 @@ locals { | |||
| validate_kms_values = !var.kms_encryption_enabled && (var.existing_kms_instance_guid != null || var.kms_key_crn != null) ? tobool("When passing values for var.existing_kms_instance_guid or/and var.kms_key_crn, you must set var.kms_encryption_enabled to true. Otherwise unset them to use default encryption") : true | |||
| # tflint-ignore: terraform_unused_declarations | |||
| validate_kms_vars = var.kms_encryption_enabled && (var.existing_kms_instance_guid == null || var.kms_key_crn == null) ? tobool("When setting var.kms_encryption_enabled to true, a value must be passed for var.existing_kms_instance_guid and var.kms_key_crn") : true | |||
| kms_service = module.crn_parser.service_name | |||
| kms_account_id = module.crn_parser.account_id | |||
| kms_key_id = module.crn_parser.resource | |||
There was a problem hiding this comment.
again your going to need ternary logic here, as the crn parser module wshould only be called if kms_key_crn is not null.
If it is null, just default these locals to null too as they wont be used
|
/run pipeline |
|
@Vipin654 please do not commit updates to common-dev-assets git submodule in your PRs, as you will end up with a conflict (like you have now) since we have other renovate automation that handles updating the git submodule in the repos. |
|
/run pipeline |
|
/run pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope Policy to Exact KMS Key
Git Issue
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Scope Policy to Exact KMS Key
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers