Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Suffix to backup configurations #377

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

rubensf
Copy link
Contributor

@rubensf rubensf commented Nov 25, 2022

The current setup sets an unique name for sql_instance for the backup jobs. However, it is possible that an user might want more than one backup job - for instance, a weekly, a monthly and a yearly.

The current setup does not allow having diff jobs with different retentions otherwise.

The current setup sets an unique name for sql_instance for the backup
jobs. However, it is possible that an user might want more than one
backup job - for instance, a weekly, a monthly and a yearly.

The current setup does not allow having diff jobs with different
retentions otherwise.
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rubensf

modules/backup/variables.tf Outdated Show resolved Hide resolved
@rubensf rubensf requested a review from a team as a code owner December 2, 2022 00:49
@comment-bot-dev
Copy link

@rubensf
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure looks unrelated.

@bharathkkb bharathkkb merged commit 0ea1968 into terraform-google-modules:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants