Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wait-for-cluster.sh] Set CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE. #284

Merged
merged 1 commit into from
Oct 17, 2019
Merged

[wait-for-cluster.sh] Set CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE. #284

merged 1 commit into from
Oct 17, 2019

Conversation

omazin
Copy link
Contributor

@omazin omazin commented Oct 17, 2019

This is due to the fact that GCP client libraries and gcloud CLI automatically check for different environment variables - GOOGLE_APPLICATION_CREDENTIALS and CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE respectively.

@morgante
Copy link
Contributor

Approved pending CI

@morgante morgante merged commit 838b7ca into terraform-google-modules:master Oct 17, 2019
omazin added a commit to omazin/terraform-google-kubernetes-engine that referenced this pull request Oct 18, 2019
@omazin
[wait-for-cluster.sh] Update the script in all submodules. Follow up t…
1668b64 
…erraform-google-modules#284.
@omazin omazin mentioned this pull request Oct 18, 2019
Merged
omazin added a commit to omazin/terraform-google-kubernetes-engine that referenced this pull request Oct 21, 2019
@omazin
[wait-for-cluster.sh] Fix terraform-google-modules#284.
8a2fddc
@aaron-lane aaron-lane added the bug Something isn't working label Oct 22, 2019
aaron-lane added a commit that referenced this pull request Oct 24, 2019
@aaron-lane
Add entry for 5.1.0 to CHANGELOG
2438e71 
Add entries:
- #282 
- #284 
- #285
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@morgante
Merge pull request terraform-google-modules#284 from omazin/master
aa9db52 
[wait-for-cluster.sh] Set CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE.
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@omazin
[wait-for-cluster.sh] Update the script in all submodules. Follow up t…
043f60e 
…erraform-google-modules#284.
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@omazin
[wait-for-cluster.sh] Fix terraform-google-modules#284.
9ffd89c
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@aaron-lane
Add entry for 5.1.0 to CHANGELOG
874b28d 
Add entries:
- terraform-google-modules#282 
- terraform-google-modules#284 
- terraform-google-modules#285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@aaron-lane aaron-lane Awaiting requested review from aaron-lane

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omazin @morgante @aaron-lane