feat: Added outputs sns_topic_name, sns_topic_id, sns_topic_owner #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner to the module
…percase in the sns topic: name, id, owner
|
Please fix the docs by running |
…, sns_topic_id, sns_topic_owner
|
Hi @antonbabenko corrected the documentation as required in the README.md |
antonbabenko
pushed a commit
that referenced
this pull request
Dec 16, 2021
|
This PR is included in version 3.3.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will add outputs to the module to allow for greater integration with terraform modules and resources
Motivation and Context
The change covers common use cases for SNS topics:
Breaking Changes
No breaking changes!
How Has This Been Tested?
Here are my test scenarios:
Created a Topic SNS and sent the following values in outputs:
sns_topic_name
sns_topic_arn
sns_topic_id
sns_topic_owner
After executing the Terraform Apply command, the correct execution was verified.
The code used to run the test is located at this repository: simoferr98/infrastructure-terraform-example
My test environment is: