-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support for new AWS region #15
fix: Support for new AWS region #15
Conversation
@bryantbiggs Looks like GH Actions does not like directories with dots, or? Failed run - https://github.com/terraform-aws-modules/terraform-aws-pricing/actions/runs/3463780846/jobs/5784485992 |
@antonbabenko I found the issue, it's because there's a directory called |
yes, its what @markandersontrocme has identified - the directory name looks like a file name to pythons |
@antonbabenko can we revert this commit (if it's the one that is causing the new GH Actions error): df3ccd8? and find the fix for the module naming later? This broken module is blocking one of our pipelines... |
Let's merge this (as is) and find the fix in GH actions later. |
### [2.0.1](v2.0.0...v2.0.1) (2022-11-15) ### Bug Fixes * Support for new AWS region ([#15](#15)) ([b1d5988](b1d5988))
This PR is included in version 2.0.1 🎉 |
this should be fixed in v1.8.3 of the action thanks to @markandersontrocme - clowdhaus/terraform-composite-actions#16 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This issue has been resolved in version 2.0.2 🎉 |
Description
Add support for new AWS region and allow users to not query all regions.
Closes #14
Motivation and Context
data.aws_regions queries all regions and when a new one is added this module breaks until AWS fixes the Terraform provider and aws-sdk-go
Breaking Changes
N/A
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request