Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated example for parameterized and holistic usage #9

Closed
wants to merge 2 commits into from

Conversation

macleanj
Copy link

@macleanj macleanj commented Jul 21, 2019

Updated example for parameterized and holistic usage (any service, any region). Normalized tagging of all resources that are created.

Description

The execution of this example failed for the following reasons:

  • necessary parameters were not parametrized. Region was hard coded and not parameterized. All instances of "region" needed to be updated to make it work
  • the instance was not accessible from the cluster. This is by default fixed (NAT gateway no longer needed as instance now resides in a public subnet)
  • the instance was not accessible from the internet. Security group auto-updated with port 80
  • Hard to find resources that belong together. Updated names and tagging.

Apologies for the big changes made. Next time I'll make them smaller ;-)

…y region). Normalized tagging of all resources that are created.
@antonbabenko
Copy link
Member

This example is too specific and includes more than necessary to show how the ECS module works. I have updated it a bit in #25 and going to close this PR.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants