Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ECS Cluster settings are dynamic (example-based tests pending) #59

Closed
wants to merge 1 commit into from

Conversation

AutomationD
Copy link

@AutomationD AutomationD commented May 20, 2022

Description

This PR converts settings section to be dynamic and removes the whole section if the container insights are disabled.

Motivation and Context

Fixes #58

Breaking Changes

No

How Has This Been Tested?

  • I have tested and validated these changes using internal project which is a simple module call.
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have executed pre-commit run -a on my pull request

@AutomationD AutomationD changed the title ECS Cluster settings are dynamic (tests pending) FIX: ECS Cluster settings are dynamic (tests pending) May 20, 2022
@AutomationD AutomationD changed the title FIX: ECS Cluster settings are dynamic (tests pending) fix: ECS Cluster settings are dynamic (tests pending) May 20, 2022
@AutomationD AutomationD changed the title fix: ECS Cluster settings are dynamic (tests pending) fix: ECS Cluster settings are dynamic (example-based tests pending) May 20, 2022
@antonbabenko
Copy link
Member

This issue has been resolved in version 4.0.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS Container insights feature is not available in some regions
2 participants