Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to ECS instance profile role #21

Conversation

saulius
Copy link
Contributor

@saulius saulius commented May 4, 2020

Description

Allows adding custom tags to ECS instance profile role.

Motivation and Context

We have a policy to tag all taggable AWS resources in the company. It would be great if we could tag this role as well.

Breaking Changes

No breaking changes, as has an empty map default.

How Has This Been Tested?

The change has been tested by referencing a fork repo with this change and applying.

@saulius saulius force-pushed the features/add_tags_to_instance_profile_module branch from 52a858f to c2d1951 Compare May 4, 2020 13:36
@antonbabenko antonbabenko merged commit 5ac7b15 into terraform-aws-modules:master Nov 9, 2020
@antonbabenko
Copy link
Member

Thanks, @saulius !

v2.5.0 has been just released where this PR and #25 were merged.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants