Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix example as Terraform performs shallow merge of nested maps #170

Conversation

ivan-sukhomlyn
Copy link
Contributor

@ivan-sukhomlyn ivan-sukhomlyn commented Feb 20, 2024

Description

Fix the example with a custom CloudWatch log group name because log_configuration.options override during the merge operation as Terraform doesn't perform a deep merge of nested maps.

Fixes #173

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@ivan-sukhomlyn ivan-sukhomlyn changed the title chore: Fix example as Terraform perform shallow merge of nested maps chore: Fix example as Terraform performs shallow merge of nested maps Feb 20, 2024
@bryantbiggs bryantbiggs changed the title chore: Fix example as Terraform performs shallow merge of nested maps docs: Fix example as Terraform performs shallow merge of nested maps Mar 4, 2024
@bryantbiggs bryantbiggs merged commit 62001b5 into terraform-aws-modules:master Mar 4, 2024
14 checks passed
@ivan-sukhomlyn ivan-sukhomlyn deleted the chore/fix_example_with_custom_log_name branch March 4, 2024 16:30
@antonbabenko
Copy link
Member

This PR is included in version 5.9.2 🎉

Copy link

github-actions bot commented Apr 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log driver awslogs requires options
3 participants