Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for disable_api_stop #218

Merged
merged 2 commits into from
Dec 15, 2022
Merged

feat: Add support for disable_api_stop #218

merged 2 commits into from
Dec 15, 2022

Conversation

schniber
Copy link
Contributor

Description

This PR implements the feature request #217

Motivation and Context

This PR allows to disable_api_stop at the launch template level.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@schniber schniber changed the title feat: addition of disable api stop feature feat: Addition of disable api stop feature Dec 15, 2022
@bryantbiggs bryantbiggs changed the title feat: Addition of disable api stop feature feat: Add support for disable_api_stop Dec 15, 2022
@bryantbiggs
Copy link
Member

we'll need to update all of the versions to at least v4.20.0 of the provider https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#4200-june-23-2022

@schniber
Copy link
Contributor Author

@bryantbiggs : Thanks for your review. well spotted !
Bests !

@bryantbiggs bryantbiggs merged commit 69415ea into terraform-aws-modules:master Dec 15, 2022
antonbabenko pushed a commit that referenced this pull request Dec 15, 2022
## [6.6.0](v6.5.3...v6.6.0) (2022-12-15)

### Features

* Add support for `disable_api_stop` ([#218](#218)) ([69415ea](69415ea))
@antonbabenko
Copy link
Member

This PR is included in version 6.6.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants