feat: Allow validating the certificate with CloudFlare

[simonweil]

Description

Added support for validating the domain with CloudFlare in addition to route53

Motivation and Context

We use CloudFlare as DNS and the automatic validation is not currently supported

Breaking Changes

None

How Has This Been Tested?

• I have tested and validated these changes using one or more of the provided examples/* projects

Will be filled if the change is acceptable by the maintainer

[simonweil]

Hi @antonbabenko
Would you accept such a change to support other DNS providers, in my case CloudFlare?

I know the change is still not ready for merge, the following will be completed assuming the direction is acceptable:

• Add backwards compatibility for DNS as validation method
• Fix variable validation to accept all allowed values
• Add required tests

If you will not accept I'll keep my fork and use it for my needs, but I assume there are more consumers for other DNS providers.

[antonbabenko]

Hi @simonweil !

Thanks for opening this PR and asking before finalizing it.

We should not make this module dependant on the Cloudflare provider (it is not possible to include the provider conditionally in Terraform).

Instead, I propose to make changes in the PR to:

1. Revert to use DNS validation method as before (backward compatibility is important here).
2. Add another variable for create_route53_records with default = true.
3. Add another variable for validation_record_fqdns which will have to be set by Cloudflare users.
4. Show in a separate example external DNS records management:

• Cloudflare and Route53 (sometimes people want to manage records outside of this module): call module "acm" and resource "cloudflare_record" "validation" together, for eg.

4. Update README pointing to a new example.

[simonweil]

OK, will try it and update

[simonweil]

@antonbabenko This actually seems to work!

[simonweil]

Added the example and link from the README.md.

I think that the only thing missing is updating the readme in the example and the main one.
Any thing else to change/fix?
How should I update the readme? is it automatic?

[antonbabenko]

Looks pretty good. I will review&test it during the week.

[simonweil]

As far as I know, all is good now.
Please review and tell me if there is anything left to do/fix.

Also should I squash the 3 commits?

[simonweil]

Docs should be fixed now

[antonbabenko]

Thank you @simonweil !

I have just finished it in #101 and released version 3.3.0.

[simonweil]

Thank you @antonbabenko!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.