fix(tur/luanti): tweak x11 patch, unapplying forced absolute mouse mode #1331

robertkirkman · 2024-11-26T12:05:35Z

remove unnecessary patch comments
remove typo ` symbol
unapply forced asbolute mouse mode. if my test indicates correctly, the bug described in the comment (luanti-org/luanti@bd15f26) is talking about something that only happens when you move a mouse, and if you stop moving the mouse and touch the screen again, the problem goes away by itself. I could be wrong and maybe there is a situation where a phantom input interrupts the touchscreen buttons with no mouse present and Termux:X11 in direct touch mode, but removing this enables more settings for keyboard in the settings menu, so if someone has a more severe problem with this, this can be reverted.

How to use keyboard: make sure that Termux:X11 is set into Prefer scancodes when possible mode. When it is not set into that mode, W, A, S and D and space keys do not work for me, but enabling that mode makes the problem completely go away.

After this PR I think this package should be moved to x11-repo, because several people asked for that, but I am not sure of the way to do it. Should I submit this PR to termux-packages repo instead, and submit a PR to delete the package here?

recommended Termux:X11 settings for luanti

"hideCutout"="false"
"displayStretch"="false"
"notificationButton1Action"="exit"
"forceOrientation"="reverse landscape"
"adjustResolution"="false"
"tapToMove"="false"
"enableAccessibilityServiceAutomatically"="false"
"backButtonAction"="toggle soft keyboard"
"xrMode"="false"
"adjustHeightForEK"="false"
"notificationTapAction"="open preferences"
"showAdditionalKbd"="false"
"stylusButtonContactModifierMode"="false"
"additionalKbdVisible"="true"
"opacityEKBar"="100"
"displayResolutionCustom"="1280x1024"
"stylusIsMouse"="false"
"clipboardEnable"="true"
"extra_keys_config"="[['ESC','/',{key: '-', popup: '|'},'HOME','UP','END','PGUP','PREFERENCES'], ['TAB','CTRL','ALT','LEFT','DOWN','RIGHT','PGDN','KEYBOARD']]"
"pauseKeyInterceptingWithEsc"="false"
"preferScancodes"="true"
"storeSecondaryDisplayPreferencesSeparately"="false"
"showIMEWhileExternalConnected"="true"
"useTermuxEKBarBehaviour"="false"
"showMouseHelper"="false"
"transformCapturedPointer"="No"
"displayResolutionExact"="1280x1024"
"keepScreenOn"="true"
"pointerCapture"="false"
"swipeDownAction"="toggle additional key bar"
"touchMode"="Direct touch"
"dexMetaKeyCapture"="false"
"scaleTouchpad"="true"
"hardwareKbdScancodesWorkaround"="true"
"notificationButton0Action"="open preferences"
"volumeUpAction"="no action"
"fullscreen"="true"
"enableGboardCJK"="false"
"Reseed"="false"
"PIP"="false"
"capturedPointerSpeedFactor"="100"
"displayResolutionMode"="native"
"swipeUpAction"="no action"
"filterOutWinkey"="false"
"displayScale"="100"
"volumeDownAction"="no action"
"showStylusClickOverride"="false"

Important

relevant settings:

"preferScancodes"="true": fix keyboard input
"touchMode"="Direct touch": fix touchscreen input

- remove unnecessary patch comments - remove typo ` symbol - unapply forced asbolute mouse mode. if my test indicates correctly, the bug described in the comment (luanti-org/luanti@bd15f26) is talking about is something that only happens when you move a mouse, and if you stop moving the mouse and touch the screen again, the problem goes away by itself. I could be wrong and maybe there is a situation where a phantom input interrupts the touchscreen buttons with no mouse present and Termux:X11 in direct touch mode, but removing this enables more settings for keyboard in the settings menu, so if someone has a more severe problem with this, this can be reverted. How to use Keyboard: make sure that Termux:X11 is set into **Prefer scancodes when possible mode**. When it is not set into that mode, W, A, S and D and space keys do not work for me, but enabling that mode makes the problem completely go away.

Copied and pasted from https://github.com/termux-user-repository/tur/tree/master/tur/luanti Previous documentation here: - termux-user-repository/tur#1295 - termux-user-repository/tur#1296 - termux-user-repository/tur#1331 - termux-user-repository/tur#1327 Summary of key points: - for better performance than normal virglrenderer-android, test using [termux-wsi-layer](termux#22353) or [new virglrenderer](termux#22385) - to use touchscreen input, set "Touchscreen input mode: Direct touch" in Termux:X11 settings - to use keyboard input, set "Prefer scancodes" in Termux:X11 settings - mouse input unimplemented/bugged

Copied and pasted from https://github.com/termux-user-repository/tur/tree/master/tur/luanti Previous documentation here: - termux-user-repository/tur#1295 - termux-user-repository/tur#1296 - termux-user-repository/tur#1331 - termux-user-repository/tur#1327 Summary of key points: - for better performance than normal virglrenderer-android, test using [termux-wsi-layer](termux#22353) or [new virglrenderer](termux#22385) - to use touchscreen input, set "Touchscreen input mode: Direct touch" in Termux:X11 settings - to use keyboard input, set "Prefer scancodes" in Termux:X11 settings - to use mouse input, set "Capture external pointer devices" in Termux:X11 settings

Copied and pasted from https://github.com/termux-user-repository/tur/tree/master/tur/luanti Previous documentation here: - termux-user-repository/tur#1295 - termux-user-repository/tur#1296 - termux-user-repository/tur#1331 - termux-user-repository/tur#1327 Summary of key points: - for better performance than normal virglrenderer-android, test using [termux-wsi-layer](termux#22353) or [new virglrenderer](termux#22385) - to use touchscreen input, set "Touchscreen input mode: Direct touch" in Termux:X11 settings - to use keyboard input, set "Prefer scancodes" in Termux:X11 settings - to use mouse input, set "Capture external pointer devices" in Termux:X11 settings - I made 6 patches, but the patch 0001-enable-egl-without-sdl2.patch is a cherry pick of luanti-org/luanti@4838eb2

Copied and pasted from https://github.com/termux-user-repository/tur/tree/master/tur/luanti Previous documentation here: - termux-user-repository/tur#1295 - termux-user-repository/tur#1296 - termux-user-repository/tur#1331 - termux-user-repository/tur#1327 Summary of key points: - for better performance than normal virglrenderer-android, test using [termux-wsi-layer](termux#22353) or [new virglrenderer](termux#22385) - to use touchscreen input, set "Touchscreen input mode: Direct touch" in Termux:X11 settings - to use keyboard input, set "Prefer scancodes" in Termux:X11 settings - to use mouse input, set "Capture external pointer devices" in Termux:X11 settings - 6 patches are unique to TUR/termux, but the patch 0001-enable-egl-without-sdl2.patch is a cherry pick of luanti-org/luanti@4838eb2

Copied and pasted from https://github.com/termux-user-repository/tur/tree/master/tur/luanti Previous documentation here: - termux-user-repository/tur#1295 - termux-user-repository/tur#1296 - termux-user-repository/tur#1331 - termux-user-repository/tur#1327 Summary of key points: - for better performance than normal virglrenderer-android, test using [termux-wsi-layer](#22353) or [new virglrenderer](#22385) - to use touchscreen input, set "Touchscreen input mode: Direct touch" in Termux:X11 settings - to use keyboard input, set "Prefer scancodes" in Termux:X11 settings - to use mouse input, set "Capture external pointer devices" in Termux:X11 settings - 6 patches are unique to TUR/termux, but the patch 0001-enable-egl-without-sdl2.patch is a cherry pick of luanti-org/luanti@4838eb2

licy183 merged commit 863de07 into termux-user-repository:master Nov 26, 2024
7 checks passed

robertkirkman mentioned this pull request Nov 26, 2024

addpkg(x11/luanti{-common,-server}): moved from TUR termux/termux-packages#22387

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tur/luanti): tweak x11 patch, unapplying forced absolute mouse mode #1331

fix(tur/luanti): tweak x11 patch, unapplying forced absolute mouse mode #1331

robertkirkman commented Nov 26, 2024 •

edited

Loading

fix(tur/luanti): tweak x11 patch, unapplying forced absolute mouse mode #1331

fix(tur/luanti): tweak x11 patch, unapplying forced absolute mouse mode #1331

Conversation

robertkirkman commented Nov 26, 2024 • edited Loading

robertkirkman commented Nov 26, 2024 •

edited

Loading