Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Code Cleanup #60

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

VILJkid
Copy link
Contributor

@VILJkid VILJkid commented Jun 18, 2024

Changes introduced

  • interface{} to any
  • Remove unnecessary formatting, and lint
  • Error handling, and code refactoring

@canack canack self-requested a review June 18, 2024 18:19
@canack
Copy link
Member

canack commented Jun 19, 2024

The code looks much better. Thank you for contributions. 🍀

@canack canack merged commit 31cd0c4 into termkit:main Jun 19, 2024
@VILJkid
Copy link
Contributor Author

VILJkid commented Jun 19, 2024

It surely does, with your awesome code! 🚀

@VILJkid VILJkid deleted the fix/interface-to-any-and-code-cleanup branch June 19, 2024 13:07
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 8, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [termkit/gama](https://github.com/termkit/gama) | minor | `v1.1.4` -> `v1.2.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>termkit/gama (termkit/gama)</summary>

### [`v1.2.0`](https://github.com/termkit/gama/releases/tag/v1.2.0)

[Compare Source](termkit/gama@v1.1.4...v1.2.0)

#### What's Changed

-   Fix "toolchain not available" error when `make build` by [@&#8203;VeyronSakai](https://github.com/VeyronSakai) in termkit/gama#55
-   General Improvement by [@&#8203;canack](https://github.com/canack) in termkit/gama#57
-   \[Fix] Documentation Lint by [@&#8203;VILJkid](https://github.com/VILJkid) in termkit/gama#59
-   \[Fix] Code Cleanup by [@&#8203;VILJkid](https://github.com/VILJkid) in termkit/gama#60
-   Feature [#&#8203;47](termkit/gama#47) : Fill workflow with empty message if no workflow inputs by [@&#8203;canack](https://github.com/canack) in termkit/gama#62
-   Added GH Token Auth to Readme by [@&#8203;Jelloeater](https://github.com/Jelloeater) in termkit/gama#68
-   Update README.md with notes for better GITHUB_TOKEN handling by [@&#8203;pirafrank](https://github.com/pirafrank) in termkit/gama#69
-   Refactor: Live Mode and General Improvements by [@&#8203;canack](https://github.com/canack) in termkit/gama#65

#### New Contributors

-   [@&#8203;VeyronSakai](https://github.com/VeyronSakai) made their first contribution in termkit/gama#55
-   [@&#8203;VILJkid](https://github.com/VILJkid) made their first contribution in termkit/gama#59
-   [@&#8203;Jelloeater](https://github.com/Jelloeater) made their first contribution in termkit/gama#68
-   [@&#8203;pirafrank](https://github.com/pirafrank) made their first contribution in termkit/gama#69

**Full Changelog**: termkit/gama@v1.1.4...v1.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS4yIiwidXBkYXRlZEluVmVyIjoiMzkuOTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants