Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed schema validation and faulty regex #561

Merged
merged 2 commits into from
Sep 21, 2017

Conversation

jsnoble
Copy link
Member

@jsnoble jsnoble commented Sep 21, 2017

i switched the regex to /(\d+)(\D+)/i which looks for numbers next to non-number characters. It looks like the schema failed becuase it did not split the numbers from the time selectors when it was being passed to dateOptions. We really need to test our schema seperate. the unit tests did not cover schema validations, we should test those in the future

@kstaken
Copy link
Member

kstaken commented Sep 21, 2017

Persistent jobs still fail with this change.

Error on slicer initialization, will attempt to retry 3 times: TypeError: end.format is not a function\n    at divideRange (/Users/kstaken/projects/opensource/teraslice/lib/readers/elasticsearch_date_range/slicer.js:380:47)\n    at getTimes (/Users/kstaken/projects/opensource/teraslice/lib/readers/elasticsearch_date_range/slicer.js:394:25)\n

@kstaken
Copy link
Member

kstaken commented Sep 21, 2017

integration and manual tests pass and persistent jobs will now run.

@kstaken kstaken merged commit 63071b2 into terascope:master Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants