Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run yarn setup at end of bump commands #3943

Merged
merged 3 commits into from
Feb 6, 2025
Merged

run yarn setup at end of bump commands #3943

merged 3 commits into from
Feb 6, 2025

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Feb 4, 2025 •
edited
Loading

This PR makes the following changes:

  • run yarn setup after the ts-scripts bump command modifies all package.json dependency versions. This ensures that the yarn.lock will be synced when the branch is pushed.
  • bump scripts from 1.10.0 to 1.10.1

@busma13 busma13 force-pushed the bump-command-yarn-setup branch 2 times, most recently from b10b385 to 24ec94e Compare February 4, 2025 14:32
@busma13 busma13 marked this pull request as ready for review February 4, 2025 14:32
@busma13 busma13 force-pushed the bump-command-yarn-setup branch from 1af1495 to 5481a09 Compare February 4, 2025 14:44
@busma13 busma13 requested review from godber and sotojn February 4, 2025 15:30
godber
godber approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I am probably the worst person to ask.

sotojn
sotojn approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@sotojn sotojn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@busma13 busma13 force-pushed the bump-command-yarn-setup branch from 5481a09 to e62eb8f Compare February 4, 2025 23:17
@busma13 busma13 force-pushed the bump-command-yarn-setup branch from e62eb8f to 280cb53 Compare February 6, 2025 15:25
@busma13 busma13 merged commit 4f8736d into master Feb 6, 2025
47 checks passed
@busma13 busma13 deleted the bump-command-yarn-setup branch February 6, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

@sotojn sotojn sotojn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busma13 @godber @sotojn