Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] fix release automation - use personal access token, log slack api failures #3905

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Jan 14, 2025

This PR makes the following changes:

  • Update publish-master.yml workflow to use the github Terascope Release App with actions/create-github-app-token@v1 to create an access token. The previous token used cannot trigger a secondary workflow.
  • Log slack API failures for debugging purposes.

@busma13 busma13 changed the title [workspace] use personal access token, log slack api failures [workspace] fix release automation - use personal access token, log slack api failures Jan 14, 2025
@busma13 busma13 marked this pull request as ready for review January 14, 2025 21:36
@busma13 busma13 requested review from godber and sotojn January 14, 2025 21:44
Copy link
Contributor

@sotojn sotojn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@godber
Copy link
Member

godber commented Jan 14, 2025

Since the version 2.12.1 was never published anywhere and the github release was deleted, I think we expect this to trigger a release.

@godber godber merged commit 45e6ccc into master Jan 14, 2025
46 checks passed
@godber godber deleted the fix-release-automation branch January 14, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants