Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chart] Set prom_metrics_display_url automatically #3886

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Dec 19, 2024

This PR makes the following changes:

  • Adds feature to helm chart template to support dynamic configuration of prom_metrics_display_url
    • If the user explicitly sets prom_metrics_display_url in the terafoundation config, the provided value is used without modification (except making sure a trailing slash is appended if missing). Ex: http://teraslice.local will end up as http://teraslice.local/ in the configmap.
    • When prom_metrics_display_url is not set, the URL is dynamically constructed based on if the ingress.enabled configuration is true or false
      • If true, it will make a url based off of the value in .Values.ingress.hosts.
        • It will also add a https:// prefix if ingress.tls is defined and non-empty. Otherwise will use http:// prefix
      • If false it will leave prom_metrics_display_url unset

Ref to issue #3852

@sotojn sotojn requested review from briend and busma13 December 19, 2024 22:07
@sotojn sotojn self-assigned this Dec 19, 2024
@briend
Copy link
Contributor

briend commented Jan 2, 2025

Looks good to me. I tested it out with helm template and verified prom_metrics_display_url looked correct for each scenario

@godber godber merged commit b36fe30 into master Jan 13, 2025
46 checks passed
@godber godber deleted the teraslice-url-helm branch January 13, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants