[Chart] Set prom_metrics_display_url automatically #3886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
prom_metrics_display_url
prom_metrics_display_url
in the terafoundation config, the provided value is used without modification (except making sure a trailing slash is appended if missing). Ex:http://teraslice.local
will end up ashttp://teraslice.local/
in the configmap.prom_metrics_display_url
is not set, the URL is dynamically constructed based on if theingress.enabled
configuration istrue
orfalse
true
, it will make a url based off of the value in.Values.ingress.hosts
.https://
prefix ifingress.tls
is defined and non-empty. Otherwise will usehttp://
prefixfalse
it will leaveprom_metrics_display_url
unsetRef to issue #3852