[teraslice] fix multi-job deletion bug in force job stop #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c82d619 to
32c4b16
Compare
busma13
commented
Sep 14, 2024
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetesV2/k8s.ts
Outdated
Show resolved
Hide resolved
|
This will require rebasing and discussion. |
62c1c02 to
39ec850
Compare
godber
approved these changes
Sep 18, 2024
a802c9b to
ce2e490
Compare
godber
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
K8s._deleteObjByExId()contains an object inobjList.items[]before callingK8s.deleted().K8s.delete()receives anameargument that is undefined or an empty string.K8s._deleteObjByExId()to delete multiple objects and not handleforce logick8s.deleteExecution() to handleforcelogic by callingK8s._deleteObjByExId()` on multiple resources.kindest/node:v1.28.12@sha256:fa0e48b1e83bb8688a5724aa7eebffbd6337abd7909ad089a2700bf08c30c6ea. Note that the version in the image tag refers to the kubernetes server version that will be used. We should keep this in sync with prod.ref: #3750