Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k8s-env --dev option #3667

Merged
merged 17 commits into from
Jul 8, 2024
Merged

Add k8s-env --dev option #3667

merged 17 commits into from
Jul 8, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Jun 21, 2024 •
edited by godber
Loading

This PR makes the following changes:

  • Adds --dev option to k8s-env command
    • This flag when enabled will add the entire teraslice repo as a volume to allow for fast build changes when running in kubernetes.
  • Adds dev compatibility to k8s master backend
  • Fixes asset-storage setting in k8s-env
    • This resolves a bug where launching k8s-env with asset-storage set to s3 would not work correctly

Refs: #3664

@sotojn sotojn self-assigned this Jun 21, 2024
@sotojn sotojn force-pushed the k8s-faster-build-time branch from 8f257b7 to 5e828c6 Compare June 24, 2024 22:14
@sotojn sotojn marked this pull request as ready for review June 24, 2024 23:18
@sotojn sotojn requested review from godber and busma13 June 24, 2024 23:19
@sotojn sotojn added enhancement k8s Applies to Teraslice in kubernetes cluster mode only. pkg/scripts feature labels Jun 24, 2024
busma13
busma13 requested changes Jun 25, 2024
View reviewed changes
@godber godber added this to the v2.1 milestone Jun 25, 2024
@sotojn sotojn force-pushed the k8s-faster-build-time branch from 0c52eb6 to c933c91 Compare July 3, 2024 21:56
@godber godber merged commit 19f6877 into master Jul 8, 2024
60 checks passed
@godber godber deleted the k8s-faster-build-time branch July 8, 2024 20:55
@godber godber temporarily deployed to github-pages July 8, 2024 21:04 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busma13 busma13 busma13 requested changes

@godber godber godber approved these changes

Assignees

@sotojn sotojn

Labels
enhancement feature k8s Applies to Teraslice in kubernetes cluster mode only. pkg/scripts
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sotojn @godber @busma13