-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user feedback when job versions don't match master #3516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, has @ciorg had a chance to provide feedback and has his concerns been addressed?
There hasn't been a commit since I reviewed it this morning - so I don't think anything has been changed yet. |
909f629
to
e7be397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
earl
will now display feedback when runningtjm
start, update, or register if the following conditions are met:kubernetes_image
field with an expected image/tag formatmy-registry/teraslice:v[version of teraslice]
johnsregistry/teraslice:v0.73.11-nodev18.18.2
kubernetes_image
Here is an example of registering a job file that has
"kubernetes_image": "terascope/teraslice:v0.73.11-nodev18.18.2"
adnd the master pod is running on teraslice v0.89.0:Ref to issue #3507