Skip to content

Commit

Permalink
fix docs and typos
Browse files Browse the repository at this point in the history
  • Loading branch information
jsnoble committed Jan 6, 2025
1 parent ccac491 commit 435f3f0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
9 changes: 3 additions & 6 deletions e2e/test/cases/assets/simple-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ describe('assets', () => {
if (TEST_PLATFORM === 'kubernetes' || TEST_PLATFORM === 'kubernetesV2') {
jobSpec.resources_requests_cpu = 0.1;
}
// the previous test confirms the newer version will be used by default
// now we test to see if we can select the older version

jobSpec.assets = ['ex1:0.0.1', 'standard', 'elasticsearch'];
const { workers } = jobSpec;

Expand Down Expand Up @@ -159,8 +158,7 @@ describe('assets', () => {
if (TEST_PLATFORM === 'kubernetes' || TEST_PLATFORM === 'kubernetesV2') {
jobSpec.resources_requests_cpu = 0.1;
}
// the previous test confirms the newer version will be used by default
// now we test to see if we can select the older version

jobSpec.assets = ['ex1:0.0.1', 'ex1:0.1.1', 'standard', 'elasticsearch'];

await expect(terasliceHarness.submitAndStart(jobSpec)).rejects.toThrow();
Expand All @@ -172,8 +170,7 @@ describe('assets', () => {
if (TEST_PLATFORM === 'kubernetes' || TEST_PLATFORM === 'kubernetesV2') {
jobSpec.resources_requests_cpu = 0.1;
}
// the previous test confirms the newer version will be used by default
// now we test to see if we can select the older version

jobSpec.assets = ['ex1:0.0.1', 'ex1:0.1.1', 'standard', 'elasticsearch'];
jobSpec.operations = jobSpec.operations.map((op) => {
if (op._op === 'drop_property') {
Expand Down
2 changes: 1 addition & 1 deletion packages/job-components/src/job-validator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export class JobValidator {
});

// this needs to happen first because it can add apis to the job
// though usage of the ensureAPIFromConfig api that called inside
// through usage of the ensureAPIFromConfig api that called inside
// many validateJob schema methods
validateJobFns.forEach((fn) => {
fn(jobConfig);
Expand Down

0 comments on commit 435f3f0

Please sign in to comment.