Add more tests

terascope · Sep 29, 2020 · 402aaf3 · 402aaf3
1 parent ee406d3
commit 402aaf3
Show file tree

Hide file tree

Showing 8 changed files with 83 additions and 20 deletions.
diff --git a/packages/data-mate/src/vector/ListVector.ts b/packages/data-mate/src/vector/ListVector.ts
@@ -11,6 +11,7 @@ export class ListVector<T = unknown> extends Vector<Vector<T>> {
             valueToJSON: ListVector.valueToJSON,
             ...options,
         });
+        this.sortable = false;
     }
 
     fork(data: Data<Vector<T>>): ListVector<T> {

diff --git a/packages/data-mate/src/vector/Vector.ts b/packages/data-mate/src/vector/Vector.ts
@@ -54,6 +54,11 @@ export abstract class Vector<T = unknown> {
     */
     readonly data: Data<T>;
 
+    /**
+     * If set to false, the Vector is not sortable
+    */
+    sortable = true;
+
     protected readonly _size: number;
 
     constructor(
@@ -123,6 +128,10 @@ export abstract class Vector<T = unknown> {
      * an array with the updated indices.
     */
     getSortedIndices(direction?: SortOrder): number[] {
+        if (!this.sortable) {
+            throw new Error(`Sorting is not supported for ${this.constructor.name}`);
+        }
+
         const indices: number[] = Array(this._size);
         const original: [number, Maybe<T>][] = Array(this._size);
 

diff --git a/packages/data-mate/src/vector/types/ObjectVector.ts b/packages/data-mate/src/vector/types/ObjectVector.ts
@@ -9,6 +9,7 @@ export class ObjectVector<
 > extends Vector<T> {
     constructor(options: VectorOptions<T>) {
         super(VectorType.Object, options);
+        this.sortable = false;
     }
 
     fork(data: Data<T>): ObjectVector<T> {

diff --git a/packages/data-mate/test/column/column-number-spec.ts b/packages/data-mate/test/column/column-number-spec.ts
@@ -271,7 +271,11 @@ describe('Column (Number Types)', () => {
             }));
         });
 
-        test.todo('should NOT be able to sort the values');
+        it('should NOT be able to sort the values', () => {
+            expect(() => {
+                col.sort();
+            }).toThrow('Sorting is not supported for ListVector');
+        });
     });
 
     describe(`when field type is ${FieldType.Long}`, () => {

diff --git a/packages/data-mate/test/column/column-string-spec.ts b/packages/data-mate/test/column/column-string-spec.ts
@@ -71,6 +71,11 @@ describe('Column (String Types)', () => {
             }));
         });
 
-        test.todo('should be immutable');
+        it('should be immutable', () => {
+            expect(() => {
+                // @ts-expect-error
+                newCol.vector = 'hi' as any;
+            }).toThrow();
+        });
     });
 });
diff --git a/packages/data-mate/test/data-frame-spec.ts b/packages/data-mate/test/data-frame-spec.ts
@@ -196,7 +196,19 @@ describe('DataFrame', () => {
         });
     });
 
-    test.todo('should be immutable');
+    it('should be immutable', () => {
+        const dataFrame = DataFrame.fromJSON({
+            version: LATEST_VERSION,
+            fields: {
+                name: { type: FieldType.Keyword }
+            }
+        }, [{ name: 'Billy' }]);
+
+        expect(() => {
+            // @ts-expect-error
+            dataFrame.columns[0] = 'hi';
+        }).toThrow();
+    });
 
     describe('when manipulating a DataFrame', () => {
         type Person = { name: string; age: number; friends: string[] }

diff --git a/packages/data-mate/test/vector/list-vector-spec.ts b/packages/data-mate/test/vector/list-vector-spec.ts
@@ -54,10 +54,5 @@ describe('ListVector', () => {
         it('should be an instance of a Vector', () => {
             expect(vector).toBeInstanceOf(Vector);
         });
-
-        test.todo('should be immutable');
     });
-
-    test.todo('->reduce');
-    test.todo('->filter');
 });
diff --git a/packages/data-mate/test/vector/vector-spec.ts b/packages/data-mate/test/vector/vector-spec.ts
@@ -11,7 +11,12 @@ import {
 import { Builder, Vector } from '../../src';
 
 describe('Vector', () => {
-    type Case = [type: FieldType, input: any[], output?: any[]];
+    type Case = [
+        type: FieldType,
+        input: any[],
+        output?: any[],
+        invalid?: any[]
+    ];
     const nowDate = new Date();
     const now = nowDate.getTime();
     const testCases: Case[] = [
@@ -21,8 +26,9 @@ describe('Vector', () => {
         ],
         [
             FieldType.String,
-            ['foo', 'bar', 1, 2, null, undefined],
-            ['foo', 'bar', '1', '2', null, null]
+            ['foo', 'bar', true, 1, 2, null, undefined],
+            ['foo', 'bar', 'true', '1', '2', null, null],
+            [{ foo: 'bar' }]
         ],
         [
             FieldType.Float,
@@ -32,7 +38,20 @@ describe('Vector', () => {
         [
             FieldType.Integer,
             [12.344, '2.01', BigInt(200), 1, 2, null, undefined],
-            [12, 2, 200, 1, 2, null, null]
+            [12, 2, 200, 1, 2, null, null],
+            [-(2 ** 31) - 1, 2 ** 31 + 1, 'foo']
+        ],
+        [
+            FieldType.Byte,
+            [12.344, '2.01', -1, 2, null, undefined],
+            [12, 2, -1, 2, null, null],
+            [128, -129, 'bar']
+        ],
+        [
+            FieldType.Short,
+            [12.344, '-2.01', 1000, 2, null, undefined],
+            [12, -2, 1000, 2, null, null],
+            [32_768, -32_769, 'baz', '++1']
         ],
         [
             FieldType.Long,
@@ -42,7 +61,8 @@ describe('Vector', () => {
         [
             FieldType.Boolean,
             ['yes', 'no', true, false, 0, 1, null, undefined],
-            [true, false, true, false, false, true, null, null]
+            [true, false, true, false, false, true, null, null],
+            ['Y E S', 'foo', 23]
         ],
         [
             FieldType.Date,
@@ -54,7 +74,8 @@ describe('Vector', () => {
                 '1941-08-20T07:00:00.000Z',
                 null,
                 null
-            ]
+            ],
+            ['not a date', Number.NaN],
         ],
         [
             FieldType.IP,
@@ -113,7 +134,7 @@ describe('Vector', () => {
                 { lat: 89.002, lon: 20.034990 },
                 null,
                 null
-            ]
+            ],
         ],
         [
             FieldType.GeoJSON,
@@ -219,10 +240,14 @@ describe('Vector', () => {
                 null,
                 null
             ],
+            [
+                [],
+                'foo',
+            ],
         ],
     ];
 
-    describe.each(testCases)('when field type is %s', (type, input, output) => {
+    describe.each(testCases)('when field type is %s', (type, input, output, invalid) => {
         let vector: Vector<any>;
         let expected: any[];
         beforeAll(() => {
@@ -265,13 +290,24 @@ describe('Vector', () => {
             }
         });
 
+        if (invalid?.length) {
+            test.each(invalid)('should NOT be able to parse %p', (val) => {
+                const builder = Builder.make({ type, array: false });
+                expect(() => {
+                    builder.append(val);
+                }).toThrowError();
+            });
+        }
+
         it('should be an instance of a Vector', () => {
             expect(vector).toBeInstanceOf(Vector);
         });
 
-        test.todo('should be immutable');
+        it('should be immutable', () => {
+            expect(() => {
+                // @ts-expect-error
+                vector.data.values[0] = '10';
+            }).toThrow();
+        });
     });
-
-    test.todo('->reduce');
-    test.todo('->filter');
 });