Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate docker images from docker.hub to ghcr registry #34

Merged
merged 15 commits into from
Jul 25, 2024
Merged

Migrate docker images from docker.hub to ghcr registry #34

merged 15 commits into from
Jul 25, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Jul 22, 2024 •
edited
Loading

This PR makes the following changes;

  • Moves docker registry from docker.hub to ghcr.io(github container registry)
  • Added more descriptive labels using the proper format stated here Teraslice Docker Images Should have Annotations (labels) teraslice#3257
  • Fixes unknown/unknown architecture that shows up in the image digest to no longer be there
  • Updates Readme to describe release workflow more clearly
  • Unpin node 22

@sotojn sotojn self-assigned this Jul 22, 2024
@sotojn sotojn marked this pull request as ready for review July 24, 2024 16:17
@sotojn sotojn requested review from godber and busma13 July 24, 2024 16:27
busma13
busma13 requested changes Jul 24, 2024
View reviewed changes
busma13
busma13 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

godber
godber approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll accept and merge my recommended changes.

@godber godber merged commit 6e1ff70 into master Jul 25, 2024
3 checks passed
@godber godber deleted the migrate-to-ghcr-registry branch July 25, 2024 15:37
@sotojn sotojn mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

@busma13 busma13 busma13 approved these changes

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotojn @godber @busma13