Skip to content

Commit

Permalink
fix: dont log GitHub app token in logs (runatlantis#4667)
Browse files Browse the repository at this point in the history
Co-authored-by: Tom Baker <tobaker@tripadvisor.com>
  • Loading branch information
2 people authored and terakoya76 committed Dec 31, 2024
1 parent 71484c2 commit e25f7ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server/events/vcs/gh_app_creds_rotator.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func (r *githubAppTokenRotator) rotate() error {
if err != nil {
return errors.Wrap(err, "Getting github token")
}
r.log.Debug("token %s", token)
r.log.Debug("Token successfully refreshed")

// https://developer.github.com/apps/building-github-apps/authenticating-with-github-apps/#http-based-git-access-by-an-installation
if err := WriteGitCreds("x-access-token", token, r.githubHostname, r.homeDirPath, r.log, true); err != nil {
Expand Down

0 comments on commit e25f7ed

Please sign in to comment.