-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics for monitoring endpoints #24
Conversation
@StrongestNumber9 please check this out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some notes
Discussed with @kortemik that an EventContextFactory can be implemented for unit testing. When producing new events with the factory, we can then call EventContextConsumer's accept() function and test the metrics by getting the Gauge's and asserting the correct value of getValue(). Later the factory can be used for testing the class's other functionality as well. I'll start working on developing this and I will add it to the PR when ready. |
Added testing for the metrics and fixed the issues that came up in the first round of review. Made a fake object for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor tweaks
src/test/java/com/teragrep/aer_01/EventContextConsumerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/teragrep/aer_01/EventContextConsumerTest.java
Outdated
Show resolved
Hide resolved
Ready with all the required fixes. @kortemik @StrongestNumber9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm at this point
Fixes #8
Added metrics for:
Dropwizard setup was inspired by CFE-35 Router.java
Needs to be tested, but this is the initial code.
UPDATE: Tests done!