Allow connections via SSH agent

[phaer]

Hi & thanks a lot for this project!

Here's a minimal implementation which allows connecting via a local SSH agent, which can be useful if the private key is either password protected or not available because it's stored on a hardware token (as is the case with my yubikey).
Is this something you would merge?

Additionally, would you welcome a breaking change in another PR which synchronizes the parameters of this providers conn blocks with modern terraforms connection blocks?

[tenstad]

Thank you for your PR! This is definitely something we could merge. Would prefer to have it tested first tho.

[tenstad]

synchronizes the parameters of this providers conn blocks with modern terraforms connection blocks

I'm up for a breaking change, what would you change?
I suppose this is the target: https://www.terraform.io/language/resources/provisioners/connection

[phaer]

I'm up for a breaking change, what would you change?
Yes, that's the right target. On second reading, it seems to be just about the block naming: conn -> connection

[tenstad]

Yes, that's the right target. On second reading, it seems to be just about the block naming: conn -> connection

If I remember correctly, terraform does not allow the block name connection. Please try to rename it and see if anything has changed, as I tested it quite some time ago.

[tenstad]

I got the tests working! If you fix the final comment, we can merge 😄

[tenstad]

@phaer could we get this one merged?

[phaer]

@tenstad Sorry for the wait, the project I am using this provider for is on ice for the moment and I had quite a few other things going on. But looks goot to me, thanks for all the fixes and the provider in general! :)

[tenstad]

Thank you for adding this @phaer ! 😄
I have now created a test for it #40, although it only works locally (#36).