Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xFail errors from pytest #6940

Merged
merged 47 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
a987571
Update nightly build to use recent nightly packages
nikelite Oct 9, 2024
23fb939
Merge branch 'tensorflow:master' into master
nikelite Oct 9, 2024
b8e5e13
Adjust version constraints
nikelite Oct 9, 2024
9031f22
Merge branch 'master' of https://github.com/nikelite/tfx
nikelite Oct 9, 2024
d099fe7
Adjust version constraints
nikelite Oct 9, 2024
4942170
Add pytest config to avoid absl.flags._exceptions.UnparsedFlagAccessE…
nikelite Oct 16, 2024
12327f6
Add pytest config to avoid absl.flags._exceptions.UnparsedFlagAccessE…
nikelite Oct 16, 2024
7e8d715
Revert "Add pytest config to avoid absl.flags._exceptions.UnparsedFla…
nikelite Oct 16, 2024
8c15807
Cleanup unused pytest import
nikelite Oct 16, 2024
d9813bc
Cleanup unused pytest import
nikelite Oct 16, 2024
8eb2958
Add xFail for kfp handler test
nikelite Oct 16, 2024
e8c142c
Include components testdata to the package build to pass unit tests
nikelite Oct 17, 2024
725b8aa
revert dependencies change
nikelite Oct 17, 2024
295b911
Merge branch 'master' of https://github.com/nikelite/tfx into pytest
nikelite Oct 17, 2024
999351f
Include components testdata to the package build to pass unit tests
nikelite Oct 17, 2024
1d0f92a
Add test constraints for unit-tests with nightly TFX libraries
nikelite Oct 18, 2024
e88e491
Update test constraints to use recent TFX libraries
nikelite Oct 18, 2024
f3f99f7
Merge branch 'master' of https://github.com/nikelite/tfx into pytest
nikelite Oct 19, 2024
57c1a0e
Merge branch 'tensorflow:master' into pytest
nikelite Oct 20, 2024
f104d60
update MANIFEST.in to include schema files
nikelite Oct 20, 2024
b3e6ae4
Revert xfail cases which conftest cannot resolve
nikelite Oct 20, 2024
aa195cb
Merge branch 'tensorflow:master' into master
nikelite Oct 20, 2024
5fa5403
Merge branch 'pytest' of https://github.com/nikelite/tfx into pytest
nikelite Oct 20, 2024
18e9de4
Re-enable xfail tests
nikelite Oct 21, 2024
c595e39
fix conflict
nikelite Oct 21, 2024
0da5561
Update vertex handler test to use mock_init inside the test function,…
nikelite Oct 22, 2024
09b3bd1
Update pytest to use pytest-subprocess plugin
nikelite Oct 22, 2024
60e630a
Fix xfail cases from __subclasses__() which is not cleaned up with py…
nikelite Oct 23, 2024
ccb4cf7
Fix lint errors
nikelite Oct 23, 2024
12de42f
Revert subprocess install
nikelite Oct 23, 2024
48eafca
Re-enable more xfail test cases
nikelite Oct 23, 2024
b7016bb
revert local pipeline test
nikelite Oct 23, 2024
e449598
Merge branch 'master' of https://github.com/nikelite/tfx
nikelite Oct 23, 2024
e1729bd
Fix xFail errors from pytest
nikelite Oct 26, 2024
1394f9d
Fix lint error
nikelite Oct 26, 2024
3354917
Fix lint error
nikelite Oct 26, 2024
b950644
Check pytest rootdir
nikelite Oct 26, 2024
970f1da
Update pytest command
nikelite Oct 26, 2024
5c4f89d
Add testdata into tfx package
nikelite Oct 27, 2024
e2c4e8d
Fix duplicate output artifact type name in test case with pytest
nikelite Oct 27, 2024
2a26c9e
keep xFail for the some e2e tests
nikelite Oct 27, 2024
33724c1
Re-enable some xfail tests
nikelite Oct 27, 2024
b09ac2a
Reflect review comments
nikelite Oct 28, 2024
b371e7c
Fix import
nikelite Oct 28, 2024
6d563b3
Clean up disable_eager_execution()
nikelite Oct 28, 2024
8c508a2
remove unused pytest
nikelite Oct 28, 2024
ff9d236
fix typo
nikelite Oct 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ jobs:
- name: Run unit tests
shell: bash
run: |
pytest -vv -m "${{ matrix.which-tests }}" tfx
pytest -m "${{ matrix.which-tests }}"
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@
from tfx.experimental.distributed_inference.graphdef_experiments.subgraph_partitioning import create_complex_graph
from tfx.experimental.distributed_inference.graphdef_experiments.subgraph_partitioning import graph_partition

tf.compat.v1.enable_eager_execution() # Re-enable eager mode
@pytest.fixture
def enable_eager_execution_at_test_end():
yield
# Re-enable eager mode that create_complex_graph diabled.
tf.compat.v1.enable_eager_execution()
smokestacklightnin marked this conversation as resolved.
Show resolved Hide resolved

class BeamPipelineTest(tf.test.TestCase):
"""A test for the beam pipeline library."""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@
from tfx.experimental.distributed_inference.graphdef_experiments.subgraph_partitioning import graph_partition
from google.protobuf import text_format

tf.compat.v1.enable_eager_execution() # Re-enable eager mode
@pytest.fixture
def enable_eager_execution_at_test_end():
yield
# Re-enable eager mode that create_complex_graph diabled.
tf.compat.v1.enable_eager_execution()

smokestacklightnin marked this conversation as resolved.
Show resolved Hide resolved

class RemoteOpLayerTest(tf.test.TestCase):
"""A test for the class _RemoteOpLayer."""
Expand Down
Loading