Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather_nd: prepare stage tries to access model .rodata #1723

Closed
vikramdattu opened this issue Feb 8, 2023 · 1 comment · Fixed by #1727
Closed

gather_nd: prepare stage tries to access model .rodata #1723

vikramdattu opened this issue Feb 8, 2023 · 1 comment · Fixed by #1727
Assignees
Labels
bug Something isn't working

Comments

@vikramdattu
Copy link
Contributor

model used: single_pose model from tf_hub:

Following lines from gather_nd OP in prepare stage try to update values from the actual model, which of course is problematic:

https://github.com/tensorflow/tflite-micro/blob/main/tensorflow/lite/micro/kernels/gather_nd.cc#L92-L100

Related issue on tflite-micro-esp-examples: espressif/esp-tflite-micro#30 (comment)

I have simply commented out the lines locally. Please suggest correct path here.

@ddavis-2015 ddavis-2015 self-assigned this Feb 8, 2023
@ddavis-2015 ddavis-2015 added the bug Something isn't working label Feb 8, 2023
ddavis-2015 added a commit to ddavis-2015/tflite-micro that referenced this issue Feb 9, 2023
@tensorflow/micro

Move the output tensor dims data for GATHER_ND using the CreateWritableTensorDimsWithCopy utility method.

bug=fixes `gather_nd`: prepare stage tries to access model `.rodata` tensorflow#1723
@ddavis-2015
Copy link
Member

@vikramdattu

Thank you for bringing this issue to the attention of the TFLM team. We appreciate your feedback regarding problems with the TFLM codebase.

This issue has been identified as a bug in the GATHER_ND kernel operator. The PR #1727 has been submitted for this issue. Once the PR is merged, this issue should automatically close.

@mergify mergify bot closed this as completed in #1727 Feb 9, 2023
mergify bot pushed a commit that referenced this issue Feb 9, 2023
@tensorflow/micro

Move the output tensor dims data for GATHER_ND using the CreateWritableTensorDimsWithCopy utility method.

bug=fixes #1723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants