FindSimilarSubGraph bug fix. #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check g2's node inside g1's visit map.
jart
approved these changes
Dec 2, 2017
|
Wow, @trisolaran, thank you so much for making this change. I believe this resolves an infinite loop I encountered within a graph (internal to Google). |
|
Thanks. glad to help. |
|
I just want to say how impressed I am with what appears to be a high impact bug fix. From what I understand, this makes it possible to view certain data sets, avoids crashes, and eliminates some of the console log spam issues we've been encountering. What an excellent contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comparing of visit pattern should be done symmetrically. we should NOT check g2's node inside g1's visit map.