Make import tensorboard as tb possible #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a lazy loader that will allow us to provide some of the
conviences TensorFlow has. For example:
import tensorboard as tb
tb.summary.scalar('foo', tensor)
Only the hourglass summary module has been made available in this namespace,
since that's probably the only thing where we're 100% positive we want this
functionality.
chihuahua
approved these changes
Nov 30, 2017
| pkg = lambda i: i # helps google sync process | ||
| mod = lambda i: lazy.LazyLoader(i[i.rindex('.') + 1:], globals(), i) | ||
|
|
||
| summary = mod(pkg('tensorboard.summary')) |
There was a problem hiding this comment.
Why does mod have to be a lambda? Why not directly call its logic.
There was a problem hiding this comment.
DRY. It actually reduces a lot of boilerplate if there's a lot of modules being imported here. Even though for now there's just one.
|
|
||
| def _load(self): | ||
| # Import the target module and insert it into the parent's namespace | ||
| module = importlib.import_module(self.__name__) |
There was a problem hiding this comment.
Got it. So here, we truly don't load the module until the _load method is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a lazy loader that will allow us to provide some of the
conviences TensorFlow has. For example:
Only the hourglass summary module has been made available in this namespace,
since that's probably the only thing where we're 100% positive we want this
functionality.