Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make category panes open by default #728

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Conversation

jart
Copy link
Contributor

@jart jart commented Nov 13, 2017

Based on user feedback, we updated the dashboards to not display search results by default. Therefore it now makes sense to have panes expanded by default, especially since we implemented pagination a few months ago.

cc: @wchargin

Based on user feedback, we updated the dashboards to not display search results
by default. Therefore it now makes sense to have panes expanded by default,
especially since we implemented pagination a few months ago.
@jart jart requested review from nfelt and chihuahua November 13, 2017 21:23
Copy link
Member

@chihuahua chihuahua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

It seems like we also had some code that was never desired like listening for category name changes.

@jart
Copy link
Contributor Author

jart commented Nov 13, 2017

We can revisit that soon. This and another change I'm about to send are higher priority fixes for an internal release.

@jart jart merged commit bf636ee into tensorflow:master Nov 13, 2017
@wchargin
Copy link
Contributor

Unless things have changed that I'm not aware of, listening for name changes is both desired and necessary. If the list of categories is [A, C] with C expanded, and we reload to add tag B so that the list is now [A, B, C], then Polymer's (lack of) reconciliation will force tab B to be expanded. To avoid this confusion, we opted to close tabs when the structure changes. What's the reasoning for reverting this?

@wchargin
Copy link
Contributor

Also, what's the reasoning for making opened a public property?

@jart jart deleted the expand-all branch November 15, 2017 02:00
@jart
Copy link
Contributor Author

jart commented Nov 15, 2017

Changes to our internal release process necessitated this follow-up to #643 (see also: #270 and #489) which had earlier been postponed. I changed the opened property only because it seemed like it might be nice. I agree with the concerns you raised. I would like to see them addressed. My goal with this change was only to bring TensorBoard back into a content-centric state. Beyond that, I defer to you.

@chihuahua
Copy link
Member

FYI, I also made the opened property public while adding the custom scalars plugin.

The plugin lets the user set a layout for the dashboard. That also meant that the user can specify which categories are open or closed.
https://github.com/tensorflow/tensorboard/blob/master/tensorboard/plugins/custom_scalar/tf_custom_scalar_dashboard/tf-custom-scalar-dashboard.html#L346

jart added a commit to jart/tensorboard that referenced this pull request Jan 12, 2018
This will prevent TensorBoard from using too many resources for anyone with a
large number of tags. In the near future we might want to solve this in a
smarter way, possibly by not rendering things outside the viewport.

See also tensorflow#728
jart added a commit that referenced this pull request Jan 12, 2018
This will prevent TensorBoard from using too many resources for anyone with a
large number of tags. In the near future we might want to solve this in a
smarter way, possibly by not rendering things outside the viewport.

See also #728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants