-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make category panes open by default #728
Conversation
Based on user feedback, we updated the dashboards to not display search results by default. Therefore it now makes sense to have panes expanded by default, especially since we implemented pagination a few months ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
It seems like we also had some code that was never desired like listening for category name changes.
We can revisit that soon. This and another change I'm about to send are higher priority fixes for an internal release. |
Unless things have changed that I'm not aware of, listening for name changes is both desired and necessary. If the list of categories is |
Also, what's the reasoning for making |
Changes to our internal release process necessitated this follow-up to #643 (see also: #270 and #489) which had earlier been postponed. I changed the opened property only because it seemed like it might be nice. I agree with the concerns you raised. I would like to see them addressed. My goal with this change was only to bring TensorBoard back into a content-centric state. Beyond that, I defer to you. |
FYI, I also made the The plugin lets the user set a layout for the dashboard. That also meant that the user can specify which categories are open or closed. |
This will prevent TensorBoard from using too many resources for anyone with a large number of tags. In the near future we might want to solve this in a smarter way, possibly by not rendering things outside the viewport. See also tensorflow#728
This will prevent TensorBoard from using too many resources for anyone with a large number of tags. In the near future we might want to solve this in a smarter way, possibly by not rendering things outside the viewport. See also #728
Based on user feedback, we updated the dashboards to not display search results by default. Therefore it now makes sense to have panes expanded by default, especially since we implemented pagination a few months ago.
cc: @wchargin