Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projector: Add selection editor #697

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

francoisluus
Copy link
Contributor

@francoisluus francoisluus commented Nov 3, 2017

In the Projector any point selections can be modified by toggling selection/deselection, which can be done for single points or a collection.

Demo here: http://tensorserve.com:6012

git clone -b projector-selection-editor https://github.com/francoisluus/tensorboard-supervise.git
cd tensorboard-supervise
git checkout 9d9a9658fa8ffbe29e55ed375f2abd97019f4591
bazel run tensorboard -- --logdir /home/emnist-2000 --host 0.0.0.0 --port 6012

Design and behavior

  1. Uses toggle button for edit mode, like "Bounding box selection".
  2. When edit mode is off Projector works exactly as before.
  3. When edit mode is on, any existing point selection will toggle selection/deselection for any chosen points, even for multiple points now selected with bounding box.
  4. Inspector panel neighbors list gets updated with appropriate distance calculated for any newly selected/added points, which are inserted correctly to keep distance sorting of neighbors list.
  5. The main point, i.e. an initial point for which a neighborhood is calculated, cannot be deselected in edit mode.
  6. Checks are in place to ensure no points are duplicated in the selection arrays.

Projector toolbar before:

Projector toolbar after:

In the Projector any point selections can be modified by toggling
selection/deselection, which can be done for single points or a
collection.
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great. I just left 1 optional comment regarding the text of the button.

@@ -292,6 +292,9 @@ <h2 id="notification-title"></h2>
<paper-icon-button id="selectMode" alt="Bounding box selection" toggles icon="image:photo-size-select-small"></paper-icon-button>
<paper-tooltip for="selectMode" position="bottom" animation-delay="0" fit-to-visible-bounds>Bounding box selection</paper-tooltip>

<paper-icon-button id="editMode" alt="Edit current selection" toggles icon="image:exposure"></paper-icon-button>
<paper-tooltip for="editMode" position="bottom" animation-delay="0" fit-to-visible-bounds>Edit current selection</paper-tooltip>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Append to current selection" might be clearer, but I'm open to other suggestions if you find that confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appending/selection is one half of the functionality, with the other half being removal/deselection. "Add/remove in current selection" is closer to the functionality that needs to be conveyed, but perhaps that's too long hence "Edit current selection".

Granted, "Edit" may be too ambiguous/vague, and "Appending to current selection" could work where deselection is just a bonus with the main intent being additional selection.

@jart jart merged commit 2e8daf8 into tensorflow:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants