Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projector: Add t-SNE pause/resume button (replaced Stop button) #691

Merged
merged 3 commits into from
Nov 15, 2017
Merged

Projector: Add t-SNE pause/resume button (replaced Stop button) #691

merged 3 commits into from
Nov 15, 2017

Conversation

francoisluus
Copy link
Contributor

@francoisluus francoisluus commented Nov 2, 2017 •
edited
Loading

Projector: Replaced t-SNE Stop button (which terminates t-SNE) with a Pause/Resume button and functionality, while retaining t-SNE auto-termination upon projection-type switch (from t-SNE to PCA or Custom).

Demo here: http://tensorserve.com:6010

git clone https://github.com/francoisluus/tensorboard-supervise.git
cd tensorboard-supervise
git checkout a6a61e902234b48ee9429f4657dea5dc0dddc300
bazel run tensorboard -- --logdir /home/$USER/emnist-2000 --host 0.0.0.0 --port 6010

Supersedes #672: Projector improvements: Pause/resume T-SNE, and 2D sprite element zoom

@francoisluus
Projector: Add T-SNE pause/resume button (replaced Stop button)
f6298ab 
Projector: Replaced T-SNE Stop button (which terminates T-SNE) with a
Pause/Resume button and functionality, while retaining T-SNE
auto-termination upon projection-type switch.
@jart jart requested review from nsthorat and dsmilkov November 8, 2017 16:50
@francoisluus francoisluus mentioned this pull request Nov 14, 2017
Closed
dsmilkov
dsmilkov approved these changes Nov 14, 2017
View reviewed changes
Copy link
Contributor

@dsmilkov dsmilkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for splitting the previous PR. This is great and you have my approval.

You will have to merge with master since there are some conflicts, due to your other PRs that I merged in master. Ping me when merge is done.

Thank you!

@francoisluus
Merge remote-tracking branch 'tensorflow/master' into projector-tsne-…
8beaa33 
…pause
@francoisluus
Merge branch 'tensorflow/master' into projector-tsne-pause
a6a61e9 
Resolved conflicts for adding pause/resume button to t-SNE projections
panel, in addition to merged perturb button.
@francoisluus
Copy link
Contributor Author

@dsmilkov Thanks, fixed conflicts to be found in a6a61e9 pushed to this PR. I updated the demo at http://tensorserve.com:6010 .

@dsmilkov dsmilkov merged commit bfcdfa9 into tensorflow:master Nov 15, 2017
@dsmilkov
Copy link
Contributor

Excellent! Merged

@francoisluus francoisluus mentioned this pull request Nov 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsmilkov dsmilkov dsmilkov approved these changes

@nsthorat nsthorat Awaiting requested review from nsthorat

Assignees
No one assigned
Labels
plugin:projector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francoisluus @dsmilkov @jart