Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Always fire rangeValueChanged event when thumb is dragged #6680

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Bug Fix: Always fire rangeValueChanged event when thumb is dragged #6680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorboard/webapp/widgets/range_input/range_input_component.ng.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
<mat-slider class="slider" [min]="min" [max]="max" [step]="calculateStepSize()">
<input
matSliderStartThumb
(valueChange)="startThumbDrag($event)"
(valueChange)="thumbDrag()"
[(ngModel)]="lowerValue"
/>
<input
matSliderEndThumb
(valueChange)="endThumbDrag($event)"
(valueChange)="thumbDrag()"
[(ngModel)]="upperValue"
/>
</mat-slider>
18 changes: 6 additions & 12 deletions tensorboard/webapp/widgets/range_input/range_input_component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,18 +113,12 @@ export class RangeInputComponent {

readonly Position = Position;

startThumbDrag(value: number) {
this.maybeNotifyNextRangeValues(
[value, this.upperValue],
RangeInputSource.SLIDER
);
}

endThumbDrag(value: number) {
this.maybeNotifyNextRangeValues(
[this.lowerValue, value],
RangeInputSource.SLIDER
);
thumbDrag() {
this.rangeValuesChanged.emit({
lowerValue: this.lowerValue,
upperValue: this.upperValue,
source: RangeInputSource.SLIDER,
});
}

calculateStepSize() {
Expand Down
20 changes: 3 additions & 17 deletions tensorboard/webapp/widgets/range_input/range_input_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ describe('range input test', () => {
);
});

it('dispatches actions when making range step change', () => {
it('dispatches actions when slider emits valueChange event', () => {
const {fixture, onRangeValuesChanged} = createComponent({
lowerValue: -1,
upperValue: 1,
Expand All @@ -130,9 +130,9 @@ describe('range input test', () => {
By.css('mat-slider input')
)[0];

sliderThumb.triggerEventHandler('valueChange', -4);
sliderThumb.triggerEventHandler('valueChange');
expect(onRangeValuesChanged).toHaveBeenCalledWith({
lowerValue: -4,
lowerValue: -1,
upperValue: 1,
source: RangeInputSource.SLIDER,
});
Expand All @@ -152,20 +152,6 @@ describe('range input test', () => {
'0.5'
);
});

it('does not trigger change when value does not change', () => {
const {fixture, onRangeValuesChanged} = createComponent({
lowerValue: -5,
upperValue: 1,
tickCount: 10,
});
const sliderThumb = fixture.debugElement.queryAll(
By.css('mat-slider input')
)[0];

sliderThumb.triggerEventHandler('valueChange', -5);
expect(onRangeValuesChanged).not.toHaveBeenCalled();
});
});

describe('input control', () => {
Expand Down