Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TensorBoard 0.4.0-rc1 #629

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Create TensorBoard 0.4.0-rc1 #629

merged 1 commit into from
Oct 7, 2017

Conversation

jart
Copy link
Contributor

@jart jart commented Oct 6, 2017

This PR starts the TensorBoard 0.4 minor series, which maps to TensorFlow 1.4.

The 0.4 branch has been cut from HEAD today for this series. The true name of this release will be 0.4.0-rc1, to conform to semver. However, in tensorboard.version and on PyPi it will be known as 0.4.0rc1 to conform to PEP 440. @gunan has informed me there are benefits to semver conformance, as we introduce more languages into the repository.

As soon as this change is merged, this release candidate will be published to PyPi. I've confirmed that pip install tensorflow-tensorboard will not choose by default to install an RC.

Then, I will send a PR to TensorFlow updating their setup.py to say tensorflow-tensorboard >= 0.4.0rc1, < 0.5.0, so they can create their release candidate. I'm confident this will work.

>>> from packaging import version
>>> version.parse('0.4.0rc0') >= version.parse('0.4.0')
False
>>> version.parse('0.4.0rc0') >= version.parse('0.4.0rc0')
True
>>> version.parse('0.4.0rc1') >= version.parse('0.4.0rc0')
True
>>> version.parse('0.4.1') >= version.parse('0.4.0rc0')
True
>>> version.parse('0.4.1rc1') < version.parse('0.5.0')
True

@jart jart requested review from nfelt and chihuahua October 6, 2017 21:10
@jart jart merged commit bec0940 into tensorflow:0.4 Oct 7, 2017
@jart jart deleted the cherry-picks branch October 7, 2017 01:02
@jart
Copy link
Contributor Author

jart commented Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants