Use HTTP/1.1 #617
Use HTTP/1.1 #617
Conversation
jart
commented
Oct 4, 2017
- Order of magnitude reduction in TCP sockets and Python threads
- Small improvement on overall page loading time
tensorboard/main.py
Outdated
| @@ -261,6 +261,12 @@ def main(unused_argv=None): | |||
| efi.inspect(FLAGS.logdir, event_file, FLAGS.tag) | |||
| return 0 | |||
| else: | |||
|
|
|||
| # If we don't use HTTP/1.1 then a new TCP socket and Python thread is | |||
There was a problem hiding this comment.
Maybe clarify that HTTP/1.0 is the default? Esp. since HTTP/2 does exist now.
Also, just checking but I assume we do in fact always sent a Content-Length header?
There was a problem hiding this comment.
Done and yes, everything sets content-length, assuming it's using http_util.Respond. We actually used to use HTTP/1.1 before we accidentally stopped doing it when we added Werkzeug. That helper was designed specifically to make sure important headers like that got set.
- Order of magnitude reduction in TCP sockets and Python threads - Small improvement on overall page loading time
|
PTAL |
| @@ -261,6 +261,13 @@ def main(unused_argv=None): | |||
| efi.inspect(FLAGS.logdir, event_file, FLAGS.tag) | |||
| return 0 | |||
| else: | |||
|
|
|||
| # The default is HTTP/1.0 for some strange reason. If we don't use | |||
There was a problem hiding this comment.
FWIW, the BasicHTTPRequestHandler docs say it's to keep people from shooting themselves in the foot by omitting Content-Length:
https://docs.python.org/2/library/basehttpserver.html#BaseHTTPServer.BaseHTTPRequestHandler.protocol_version
But yeah, it seems like HTTP/1.1 should be the default and BaseHTTPRequestHandler should just die on you if you attempt to send a response with no content length.