tensorboard-data-server: add Linux aarch64 support #6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2022
|
@JamesHollyer Is this ok to merge? |
|
I think this update seems like a good idea. The tests failed but I think it might have actually been a flake. I am rerunning the job to find out. |
qihach64
pushed a commit
to qihach64/tensorboard
that referenced
this pull request
Dec 19, 2022
* Motivation for features / changes When building tensorboard-data-server from source on Linux aarch64, pip install raises the following error: ``` pip._internal.exceptions.UnsupportedWheel: tensorboard_data_server-0.6.1-py3-none-manylinux2010_aarch64.whl is not a supported wheel on this platform. ``` * Technical description of changes From what I can tell, manylinux2014 is the first version that supports aarch64. TensorFlow also moved to manylinux2014, so there should be no issues with us updating as well: https://pypi.org/project/tensorflow/#files * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) I don't have access to Linux aarch64 myself (this was discovered in our CI) but anyone who does should be able to confirm that this works using: ```console $ cd tensorboard/data/server $ cargo build --release $ cd pip_package $ python3 build.py $ pip install *.whl ``` * Alternate designs / implementations considered Alternatively, we could use manylinux2010 on x86_64 and manylinux2014 on all other architectures, but I see no reason to avoid manylinux2014. This is sort of a follow-up to tensorflow#5715, @japie1235813 may be willing to review this
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* Motivation for features / changes When building tensorboard-data-server from source on Linux aarch64, pip install raises the following error: ``` pip._internal.exceptions.UnsupportedWheel: tensorboard_data_server-0.6.1-py3-none-manylinux2010_aarch64.whl is not a supported wheel on this platform. ``` * Technical description of changes From what I can tell, manylinux2014 is the first version that supports aarch64. TensorFlow also moved to manylinux2014, so there should be no issues with us updating as well: https://pypi.org/project/tensorflow/#files * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) I don't have access to Linux aarch64 myself (this was discovered in our CI) but anyone who does should be able to confirm that this works using: ```console $ cd tensorboard/data/server $ cargo build --release $ cd pip_package $ python3 build.py $ pip install *.whl ``` * Alternate designs / implementations considered Alternatively, we could use manylinux2010 on x86_64 and manylinux2014 on all other architectures, but I see no reason to avoid manylinux2014. This is sort of a follow-up to tensorflow#5715, @japie1235813 may be willing to review this
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* Motivation for features / changes When building tensorboard-data-server from source on Linux aarch64, pip install raises the following error: ``` pip._internal.exceptions.UnsupportedWheel: tensorboard_data_server-0.6.1-py3-none-manylinux2010_aarch64.whl is not a supported wheel on this platform. ``` * Technical description of changes From what I can tell, manylinux2014 is the first version that supports aarch64. TensorFlow also moved to manylinux2014, so there should be no issues with us updating as well: https://pypi.org/project/tensorflow/#files * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) I don't have access to Linux aarch64 myself (this was discovered in our CI) but anyone who does should be able to confirm that this works using: ```console $ cd tensorboard/data/server $ cargo build --release $ cd pip_package $ python3 build.py $ pip install *.whl ``` * Alternate designs / implementations considered Alternatively, we could use manylinux2010 on x86_64 and manylinux2014 on all other architectures, but I see no reason to avoid manylinux2014. This is sort of a follow-up to tensorflow#5715, @japie1235813 may be willing to review this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building tensorboard-data-server from source on Linux aarch64, pip install raises the following error:
From what I can tell, manylinux2014 is the first version that supports aarch64. TensorFlow also moved to manylinux2014, so there should be no issues with us updating as well: https://pypi.org/project/tensorflow/#files
N/A
I don't have access to Linux aarch64 myself (this was discovered in our CI) but anyone who does should be able to confirm that this works using:
Alternatively, we could use manylinux2010 on x86_64 and manylinux2014 on all other architectures, but I see no reason to avoid manylinux2014.
This is sort of a follow-up to #5715, @japie1235813 may be willing to review this