cli: note when data server is used implicitly #4785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We’d like to set
--load_fast=auto
as the default for TensorBoard 2.5.To make that less surprising, we now print an informational message when
--load_fast
is set toauto
and the data server is actually used. Wedon’t show it with
--load_fast=true
; if you pass that, we assume thatyou know what you’re doing. The message looks like:
Test Plan:
Run with
--load_fast
set tofalse
,auto
, andtrue
, and note thatthe message only appears when set to
auto
. Then uninstall the dataserver and run with
auto
, and note that the message does not appear.wchargin-branch: cli-data-server-message