Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the user expand/collapse the graph legend #476

Merged
merged 2 commits into from
Sep 7, 2017
Merged

Conversation

chihuahua
Copy link
Member

@chihuahua chihuahua commented Sep 5, 2017

Without this change, the tall legend runs into the content on top of it. The legend is expanded by default.

Screenshots (expanded and closed):

c9vwa6xnw6k

peyyzzhe0nw

This fixes #396.

@dsmilkov
Copy link
Contributor

dsmilkov commented Sep 7, 2017

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

@chihuahua chihuahua merged commit 0eca31f into master Sep 7, 2017
@chihuahua chihuahua deleted the chihuahua-legend branch September 7, 2017 22:16
jart pushed a commit to jart/tensorboard that referenced this pull request Sep 23, 2017
jart pushed a commit that referenced this pull request Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The legend in the graph explorer overlaps with content
2 participants