Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a "Functions" scene group if the graph being visualized has a function library, which contains definitions for functions (templates for subgraphs) used in the TensorFlow graph.
As part of that effort, this change also strips the arbitrary hexadecimal suffix from names of functions in the graph. That suffix is not user-generated - it merely serves to distinguish between functions with the same name but different signatures.
This refactors the implementation to prefix metanodes representing functions with
FUNCTION_LIBRARY_NODE_PREFIX
instead of lumping them under a metanode namedFUNCTION_LIBRARY_NODE
. We now also remove the function metanodes from the core graph later when building the sub-hierarchy instead of excluding them in the first place from the__root__
metagraph. That lets us use existing paths to render the metanodes for functions in the scene group.The metanodes in the scene group (which represent function definitions) are not yet linked to individual calls throughout the graph - that will happen in a later change.
This change is complex and will be tested via internal Selenium-based integration tests.
Screenshot: