Uploader: Add test for completely empty GraphDef blob. #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caisq
reviewed
Apr 14, 2020
tensorboard/dataclass_compat_test.py
Outdated
Comment on lines
289
to
293
| new_event = new_events[1] | ||
| tensor = tensor_util.make_ndarray(new_event.summary.value[0].tensor) | ||
| new_graph_def_bytes = tensor[0] | ||
| new_graph_def = graph_pb2.GraphDef.FromString(new_graph_def_bytes) | ||
| self.assertProtoEquals(new_graph_def, graph_pb2.GraphDef()) |
There was a problem hiding this comment.
Can you add a comment here to explain what these lines are doing and how they are related to the lines above?
There was a problem hiding this comment.
Simplified the test (the last few lines were quite superfluous) and added comments.
bileschi
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.