data: add tests for blob sequence handling #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin-branch: data-blob-sequence-tests wchargin-source: 664b9b53b60a76eacbd85ecca3335e62c172acf0
wchargin-branch: data-blob-sequence-tests wchargin-source: e657e58995373fa202f2ec50573c23c1aa56c947
nfelt
approved these changes
Mar 26, 2020
| for (name, color, description) in data: | ||
| image_1x1 = tf.constant([[[color]]], dtype=tf.uint8) | ||
| for i in xrange(1, 11): | ||
| k = 6 - abs(6 - i) # 1, .., 6, .., 2 |
There was a problem hiding this comment.
Could you add a comment like "Use a non-monotonic sequence of sample sizes to test max_length calculation" or something? Wasn't obvious to me why the formula for k had to be this way otherwise.
There was a problem hiding this comment.
Ah, yes, sure. (Yes, that’s the reason.) Done.
wchargin-branch: data-blob-sequence-tests wchargin-source: 317d4fc9ae0fb952360f5aa7a2f8c235ffc6b177
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Apr 15, 2020
Summary: Follow-up to tensorflow#2991. Fixes tensorflow#3434. Test Plan: Tests pass as written. wchargin-branch: data-blob-sequence-tests
bileschi
pushed a commit
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow-up to #2991. Fixes #3434.
Test Plan:
Tests pass as written.
wchargin-branch: data-blob-sequence-tests