uploader: add metadata to experiment listing RPC #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This extends the `StreamExperiments` RPC such that the client can specify a set of additional metadata fields that the server should include, like “creation time” or “number of scalar points”. The format is both forward- and backward-compatible. Servers are expected to send responses with both `experiment_ids` and `experiments` until we drop support for clients that do not support `experiments`, at which point they need only send `experiments`. Test Plan: Unit test added to simulate the future behavior of servers. wchargin-branch: streamexperiments-metadata
|
Leaving this as a draft; I’ll write the server-side implementation and |
wchargin-branch: streamexperiments-metadata wchargin-source: a9770c6a0a6f1a56a96721b4437ca33bb15974d0
wchargin-branch: streamexperiments-metadata wchargin-source: a9770c6a0a6f1a56a96721b4437ca33bb15974d0
wchargin-branch: streamexperiments-metadata wchargin-source: eb73c9b8d1d48e3a0830ac4c6793a953e75e9b62
|
Googlers, see server-side implementation in http://cl/281200267. |
nfelt
approved these changes
Nov 20, 2019
|
Closing and re-opening to trigger CI… |
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Nov 25, 2019
Summary: This extends the `StreamExperiments` RPC such that the client can specify a set of additional metadata fields that the server should include, like “creation time” or “number of scalar points”. The format is both forward- and backward-compatible. Servers are expected to send responses with both `experiment_ids` and `experiments` until we drop support for clients that do not support `experiments`, at which point they need only send `experiments`. Test Plan: Unit test added to simulate the future behavior of servers. wchargin-branch: streamexperiments-metadata
Merged
wchargin
added a commit
that referenced
this pull request
Nov 25, 2019
Summary: This extends the `StreamExperiments` RPC such that the client can specify a set of additional metadata fields that the server should include, like “creation time” or “number of scalar points”. The format is both forward- and backward-compatible. Servers are expected to send responses with both `experiment_ids` and `experiments` until we drop support for clients that do not support `experiments`, at which point they need only send `experiments`. Test Plan: Unit test added to simulate the future behavior of servers. wchargin-branch: streamexperiments-metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This extends the
StreamExperimentsRPC such that the client canspecify a set of additional metadata fields that the server should
include, like “creation time” or “number of scalar points”.
The format is both forward- and backward-compatible. Servers are
expected to send responses with both
experiment_idsandexperimentsuntil we drop support for clients that do not support
experiments, atwhich point they need only send
experiments.Test Plan:
Unit test added to simulate the future behavior of servers.
wchargin-branch: streamexperiments-metadata