Fix threshold optimizations in WIT #2682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polymer2 update broke the updating of threshold sliders in WIT when certain optimization buttons are pressed.
Simplified threshold setting data-binding logic. No longer is there a map and a list to the same threshold information that is data-bound to paper-sliders. Now there is a simple list and the map is still used to quickly find items in the list by slice, but the map contains an index to the list and not the same object as is contained in the list. This fixes the issue where the updates to the slider bound values doesn't always cause the physical slider to update its setting.
Ran through demos apps, sliced performance statistics by a feature, and verified that all threshold optimization buttons now correctly update the sliders, whereas before the sliders would stay stuck in one position even though other information would correctly update.